Skip to content

Add diagnostic to enforce lowercase local element names #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Mar 30, 2023
Merged

Add diagnostic to enforce lowercase local element names #2

merged 27 commits into from
Mar 30, 2023

Conversation

AndreaWalchshoferSCCH
Copy link
Collaborator

@AndreaWalchshoferSCCH AndreaWalchshoferSCCH commented Feb 14, 2023 •
edited
Loading

  • diagnostic 'uppercase-local' in group 'conventions', disabled by default
  • isolated unit tests for diagnostic

Requires AlWoSp/vscode-lua-by-sumneko#2 for usage

@AndreaWalchshoferSCCH
Add warning for any global variable via diagnostic
402f921 
TODO: add messages in languages other than en-us as well
@AndreaWalchshoferSCCH
Rename diagnostic
d2c9737
@AndreaWalchshoferSCCH
Remove Todo
38668d6
@AndreaWalchshoferSCCH
Add messages in all languages
4b763bc
@AndreaWalchshoferSCCH
Cleanup comments, disable by default
0a2043c
@AndreaWalchshoferSCCH
Prepare test cases
e367c2a
@AndreaWalchshoferSCCH
fallback: enable/disable diagnostics w/ annotation
eee0ef2
@AndreaWalchshoferSCCH
Change to proper configuration
f6b7ed6
@AndreaWalchshoferSCCH
complete test suite for diagnostic
f22775f
@AndreaWalchshoferSCCH
Add tests to execution, reset settings at the end
9d9ae1d
@AndreaWalchshoferSCCH
Set up new diagnostic uppercase-local
fc144a7
@AndreaWalchshoferSCCH
Implement basic diagnostic
45e215a
@AndreaWalchshoferSCCH
Fix diagnostic - correctly apply to local elements
67e7d59
@AndreaWalchshoferSCCH
Add unit tests for new diagnostic
b6d2416
@AndreaWalchshoferSCCH
uncomment preexisting test
7b706a7
@AndreaWalchshoferSCCH
undo unnecessary change
12770d7
@AndreaWalchshoferSCCH
Merge branch 'awa/warning-for-any-global' into awa/enforce-local-lowe…
374cebc 
…rcase
@AndreaWalchshoferSCCH AndreaWalchshoferSCCH changed the base branch from awa/warning-for-any-global to master February 14, 2023 16:07
@AndreaWalchshoferSCCH AndreaWalchshoferSCCH changed the title Awa/enforce local lowercase Add diagnostic to enforce lowercase local element names Feb 14, 2023
@AndreaWalchshoferSCCH AndreaWalchshoferSCCH marked this pull request as ready for review February 14, 2023 16:27
@AndreaWalchshoferSCCH
Copy link
Collaborator Author

Should be merged after #1

AlWoSp
AlWoSp requested changes Mar 28, 2023
View reviewed changes
@AndreaWalchshoferSCCH
Copy link
Collaborator Author

Also, diagnostic group possibly has to be renamed back to conventions due to feedback from sumneko, but that should covered by a merge from master then

@AlWoSp AlWoSp merged commit 4379419 into master Mar 30, 2023
AndreaWalchshoferSCCH added a commit that referenced this pull request Mar 30, 2023
@AndreaWalchshoferSCCH
Revert "Add diagnostic to enforce lowercase local element names (#2)"
6a4faaa 
This reverts commit 4379419.
AndreaWalchshoferSCCH added a commit that referenced this pull request Mar 30, 2023
@AndreaWalchshoferSCCH
Revert "Add diagnostic to enforce lowercase local element names (#2)" (…
4eb508f 
…#5)

This reverts commit 4379419.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlWoSp AlWoSp AlWoSp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreaWalchshoferSCCH @AlWoSp