Fixes: Add stretching of modules and modules-center toggling #3881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmccombs do you have any other parts to discuss |
tmccombs
approved these changes
Jan 13, 2025
|
Is there anything more that needs to be done here? I'd appreciate it, if this would be merged to fix the mistakes I made. |
tmccombs
approved these changes
Feb 18, 2025
TripleTrable
force-pushed
the
AModules/fix-expand-fill-no-center
branch
from
c398ea3 to
8a15cba
Compare
Thanks to tmccombs this commit fixes some inconsitencies in Alexays#3730. These inconsitencies were: - Fixed the oversight of missing the implementation of expand_center for center_ and right_ - Removes a last minut printf debugging statment I missed.
|
LGTM, sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to tmccombs this commit fixes some inconsitencies in #3730. These inconsitencies were:
These two points were a mistake on my site and I should have reviewd my PR more carefully before publishing.
I am sorry for the inconvenience