hyprland/workspaces: fix crash #4024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
force-pushed
the
hyprland-crash
branch
from
839749c to
91ef6e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been getting nonstop crashes for a while, finally looked into it. Saw a bunch of messages in logs about failing to parse IPC messages and the crash always happening with a core dump pointing at the
onWindowTitleEventparsing. Looks like we didn't check if we reached the end of the iterator before accessing, like we did in most of the handlers.Also some quick lint cleanup for using range find iterator instead of find with explicit begin and end.