Skip to content

Fix bug in addNewRole #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

schiltz3
Copy link
Collaborator

@schiltz3 schiltz3 commented Sep 6, 2022

Fixes bug introduced in #22 Where roles were not being retrieved from the db correctly

  • switch on the wrong field
  • forgot break
  • didn't capitalize the query field

switch on wrong field
forgot `break`
didn't capitalize query field
Copy link
Member

@nathen418 nathen418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxed

@schiltz3 schiltz3 merged commit 1f391bf into staging Sep 6, 2022
@schiltz3 schiltz3 deleted the bugfix/schiltz3/addNewRoles-Fix branch September 7, 2022 03:21
nathen418 added a commit that referenced this pull request Sep 7, 2022
## New in version 2.2.1
- Many more bugfixes, dependency updates
- Added contributing standards and pull request templates
- Added interfaces and strong typing to all database calls
- Updated workflows to work on the correct branches
- Refined branch protection rules to make collaboration easier

## Merged Pull Requests
* Update README.md by @nathen418 in #14
* Create dependabot.yml by @nathen418 in #15
* Bump chalk from 4.1.2 to 5.0.1 by @dependabot in #18
* Bump mongoose from 6.5.3 to 6.5.4 by @dependabot in #16
* Nathen418/update dependabot by @nathen418 in #19
* merge main into staging by @nathen418 in #20
* update what branches workflows to run on correct branches and triggers by @schiltz3 in #24
* Add Contributing Standards  by @nathen418 in #25
* PR template by @schiltz3 in #26
* Add interfaces for models by @schiltz3 in #22
* Fix bug in `addNewRole` by @schiltz3 in #29
* Bugfix/schiltz3/deepsource by @schiltz3 in #28

## New Contributors
* @dependabot made their first contribution in #18

**Full Changelog**: v2.2.0...v2.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants