Implement CompositeFunctionMetadataProvider to allow metadata transformation #3145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
liliankasem
commented
Aug 11, 2025
| @@ -48,7 +48,11 @@ public static IServiceCollection AddGrpc(this IServiceCollection services) | |||
| services.TryAddSingleton<IWorkerDiagnostics, GrpcWorkerDiagnostics>(); | |||
|
|
|||
| // FunctionMetadataProvider for worker driven function-indexing | |||
| services.TryAddSingleton<IFunctionMetadataProvider, DefaultFunctionMetadataProvider>(); | |||
| // services.TryAddSingleton<IFunctionMetadataProvider, DefaultFunctionMetadataProvider>(); | |||
| services.TryAddKeyedSingleton<IFunctionMetadataProvider>("core", new DefaultFunctionMetadataProvider()); | |||
There was a problem hiding this comment.
Could also implement a new interface here instead of using Keyed services
There was a problem hiding this comment.
I am guessing the goal of this is to negotiate a conflict with the source generated IFunctionMetadataProvider. An option would be to change it to generate your new IFunctionMetadataTransformer contract instead. That is the approach I took in my draft PR (I think)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
release_notes.mdAdditional information
Rough draft of feature to allow augmentation of the FunctionMetadata.
Works E2E with: Azure/azure-functions-mcp-extension#88