Rethrow RpcException on invocation as InvocationException

[pragnagopa]

Related incident #4192
RpcException on invocation failure is confusing. Need to rethrow it as InvocationException instead.

[liliankasem]

When an RpcException is logged in Application Insights, the exception starts with Microsoft.Azure.WebJobs.Script.Workers.Rpc.RpcException, this makes it seem like a platform error but in almost every case it is an unhandled user code exception. The suggestion here is to create a new exception to make it clear that this is a user code issue, i.e. InvocationException. Whilst creating this new exception, it is also a good opportunity to add more information to the exception we throw. This will be a breaking change and should be put behind a flag.

Anyone picking up this issue should flesh out the design for the new exception before implementation.

Worth noting FunctionInvocationException already exists in the WebJobs SDK. Part of this issue will be to determine if we reuse that or create a new one

[JustinGrote]

Thank you @liliankasem,

I really want the full exception details in Application Insights one way or the other, if the worker has a way to hook and deliver the worker-specific exception to application insights before it also ends up showing up as an invocationexception, that is ideal.

The story I want is that when I go to Application Insights and click the Exceptions tab, whether I am in the Powershell worker or another worker, that my specific exception types show up in the list and I don't have to deal with filtering for an innerexception. Just replacing 5000 "RPCException" with 5000 "InvocationException" doesn't meet this need, I expect to see "HttpRequestException" alongside "NullPointerException", etc. at the code level here.

This is not helpful;

I need those 123k exceptions broken down by their specific exception type.

These work items you linked doesn't seem to explicitly address this issue.