Skip to content

Update worker.config.json to include profiles that enable and disable app insights #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 12, 2022
Merged

Update worker.config.json to include profiles that enable and disable app insights #586

merged 4 commits into from
Jul 12, 2022

Conversation

shreyas-gopalakrishna
Copy link
Member

Profiles are configured in worker config to enable and disable app insights.

resolves #585

Profiles: Azure/azure-functions-host#8365

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kaibocai kaibocai linked an issue Jun 24, 2022 that may be closed by this pull request
'worker.config.json' configuration hardcoded for Windows #421
Closed
@kaibocai
Copy link
Member

Just wonder is it possible to fix this issue in the same pr. Thanks.

@shreyas-gopalakrishna shreyas-gopalakrishna merged commit 1e63421 into dev Jul 12, 2022
@shreyas-gopalakrishna shreyas-gopalakrishna deleted the shreyasg/profiles-config branch July 12, 2022 18:20
kaibocai added a commit that referenced this pull request Jul 22, 2022
@kaibocai
Revert "Update worker.config.json to include profiles that enable and…
c701f93 
… disable app insights (#586)"

This reverts commit 1e63421.
@kaibocai kaibocai mentioned this pull request Jul 22, 2022
Merged
kaibocai added a commit that referenced this pull request Jul 22, 2022
@kaibocai
Revert "Update worker.config.json to include profiles that enable and…
1052102 
… disable app insights (#586)" (#598)

This reverts commit 1e63421.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaibocai kaibocai kaibocai approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio TsuyoshiUshio is a code owner

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application insights agent will be part of the java worker 'worker.config.json' configuration hardcoded for Windows
2 participants
@shreyas-gopalakrishna @kaibocai