Added a column-major demo for lcddrvce #623
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const int dD_jump = 2 * (dY - dX); | ||
| dY *= 2; | ||
|
|
||
| uint8_t* buffer = (uint8_t*)lcd_LpBase + (x0 * LCD_HEIGHT) + y0; |
There was a problem hiding this comment.
I would probably use (uint8_t*)gfx_vbuffer or &gfx_vbuffer[0][0] in an example like this, because lcd_LpBase is only semi-documented in relation to GraphX and it's not immediately clear what it means.
| const uint8_t color = line_color; | ||
|
|
||
| uint24_t x = (uint24_t)(x1 - x0); | ||
| for (; x --> 0;) { |
There was a problem hiding this comment.
This is cute and all but probably doesn't belong in an example. How about this equivalent (well, equivalent because x isn't used inside the loop):
for(uint24_t x = (uint24_t)dX; x > 0; x--) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of the previous attempt: #609
This demo shows how
lcddrvcecan be used to set the screen to column-major mode. It is similar to thegraphx/buffered_cubeexample, but shows how column-major mode can be used to remove diagonal screen tearing.Not exactly sure what comments I should add to the line drawing code.