Temporary fix for Azure OpenAI endpoints #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
CJCrafter
requested changes
Jun 7, 2023
| @@ -26,13 +26,15 @@ class AzureOpenAI @JvmOverloads constructor( | |||
| ) : OpenAI(apiKey, organization, client) { | |||
|
|
|||
| override fun buildRequest(request: Any, endpoint: String): Request { | |||
| val removedV1Endpoint = endpoint.removePrefix("v1/") // temporary fix for Azure, as it doesn't support v1/ in the url | |||
There was a problem hiding this comment.
Instead of removing the prefix from the endpoint, a slightly more version stable method would be to have overridable functions for endpoints in the OpenAI class. This way, if OpenAI moves something to V2 we can easily change that in code with creating clutter anywhere else.
AzureOpenAI can override these methods with their own endpoints, and can even throw an exception for unsupported endpoints.
| val openai = AzureOpenAI(key) | ||
| val modelName = dotenv()["OPENAI_MODEL"] | ||
| val azureBaseUrl = dotenv()["OPENAI_AZURE_BASE_URL"] | ||
| val openai = AzureOpenAI(key, modelName = modelName, azureBaseUrl = azureBaseUrl) |
There was a problem hiding this comment.
Errors like this should definitely have a check in the constructor, or the arguments should be redone so the azure arguments come before the optional ones. A builder class is also an option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.