Skip to content

Avoid DocumentData prototype overriding (#128) #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2021
Merged

Avoid DocumentData prototype overriding (#128) #129

merged 1 commit into from
Mar 16, 2021

Conversation

berdyshev
Copy link
Contributor

@berdyshev berdyshev commented Mar 16, 2021 •
edited
Loading

such modification breaks type casting using withConverter (fixes #128)

@berdyshev berdyshev changed the title Avoid modifying the prototype of DocumentData (#128) Avoid DocumentData prototype overriding (#128) Mar 16, 2021
@berdyshev
Copy link
Contributor Author

I left transform method, but I'm not sure it's needed in this limited form

@chrisbianca chrisbianca merged commit 8a6f8a5 into CSFrequency:master Mar 16, 2021
@chrisbianca
Copy link
Contributor

@berdyshev Thanks, this is a good spot. The withConverter functionality is something that I had missed being added to Firestore. I'll have a think about whether it negates the need to have the transform functionality completely.

@berdyshev berdyshev deleted the support-withConverter branch March 18, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbianca chrisbianca chrisbianca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support withConverter
2 participants
@berdyshev @chrisbianca