Changed error type to FirebaseError #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucacasonato Thanks for this, it's a great spot! I've merged and made a few minor tweaks here to fix the flow type and move the I'll get a bug release out shortly. |
|
👍 |
|
This has been released as part of v1.2.1: https://github.com/CSFrequency/react-firebase-hooks/releases/tag/v1.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error type used to be
objectbut this prevented autocomplete and Typescript strictly checking types without the user having to manually specify the type witherror as FirebaseErroror<FirebaseError>error. This has been corrected so the error type is alwaysFirebaseError.I don't know how Flow works so I think what I did should work but I am not sure.