Skip to content

Conversation

moicalcob
Copy link
Contributor

  • Added new environment variables for authentication, BigQuery, feature flags, and various storage configurations.
  • Improved organization of configuration sections with clear comments for better readability.
  • Included support for external Redis and various storage providers (GCP, S3, Azure).
  • Updated logging and PubSub configurations to ensure comprehensive setup for workspace API.

- Added new environment variables for authentication, BigQuery, feature flags, and various storage configurations.
- Improved organization of configuration sections with clear comments for better readability.
- Included support for external Redis and various storage providers (GCP, S3, Azure).
- Updated logging and PubSub configurations to ensure comprehensive setup for workspace API.
@moicalcob moicalcob self-assigned this Sep 1, 2025
@moicalcob moicalcob added the release-changes Deploy changes in a Replicated channel label Sep 1, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @moicalcob, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the configmap.yaml for the workspace API by introducing a more structured and comprehensive configuration approach. The changes aim to improve the clarity and manageability of environment variables, enable new features, and broaden support for various external services and cloud providers, ultimately making the workspace API more robust and adaptable to different deployment environments.

Highlights

  • Enhanced Configuration Organization: The configmap.yaml file for the workspace API has been significantly refactored to include clear, categorized sections for environment variables, improving readability and maintainability.
  • Expanded Environment Variables: Numerous new environment variables have been introduced to support various functionalities, including enhanced authentication, BigQuery settings, feature flags, Google Basemaps, and data warehouse enablement.
  • Improved Redis Configuration: Explicit support for external Redis instances has been added, allowing for more flexible deployment options through the USING_EXTERNAL_REDIS variable.
  • Comprehensive Storage Provider Support: The configuration now clearly delineates and supports multiple storage providers (GCP, AWS S3, Azure Blob Storage) for imports and thumbnails, along with related AWS EKS Pod Identity settings.
  • Updated Logging and PubSub Settings: Logging and PubSub configurations have been refined and organized, including the explicit definition of event bus project and topic IDs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

github-actions bot commented Sep 1, 2025

Changes release to Replicated on channel feature_sc_507365_inject_new_needed_env_vars_in_docker_compose! Check the Replicated Dashboard for more details.
If you need to test the changes, you can assign the channel to your customer and download the latest version from the Admin Console.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the organization of the configmap.yaml for the workspace API. By grouping related environment variables under commented sections, the configuration is now much more readable and maintainable. The addition of new configuration options for authentication, storage, and other features is also well-implemented. My review includes one suggestion to address potential configuration duplication, which could further enhance maintainability.

Copy link

github-actions bot commented Sep 1, 2025

Changes release to Replicated on channel feature_sc_507365_inject_new_needed_env_vars_in_docker_compose! Check the Replicated Dashboard for more details.
If you need to test the changes, you can assign the channel to your customer and download the latest version from the Admin Console.

Copy link

github-actions bot commented Sep 5, 2025

Changes release to Replicated on channel feature_sc_507365_inject_new_needed_env_vars_in_docker_compose! Check the Replicated Dashboard for more details.
If you need to test the changes, you can assign the channel to your customer and download the latest version from the Admin Console.

@moicalcob moicalcob requested a review from a team September 8, 2025 10:04
@moicalcob moicalcob changed the title Enhance workspace API configuration in configmap.yaml Add new env variables in Workspace API configmap to get details about each SH installation Sep 8, 2025
Copy link
Contributor

@RuBiCK RuBiCK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moicalcob moicalcob merged commit 2732fc6 into main Sep 8, 2025
4 checks passed
@moicalcob moicalcob deleted the feature/sc-507365/inject-new-needed-env-vars-in-docker-compose branch September 8, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-changes Deploy changes in a Replicated channel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants