Merge wasi-misc-tests repo as a subdir #174

kubkon · 2019-11-06T14:09:13Z

This commit merges CraneStation/wasi-misc-tests repo as a subdir
of this repo while preserving all of git history. There is an
initiative to pull wasi-common and wasi-misc-tests into
CraneStation/wasmtime, and CraneStation/wasmtime becoming a
monorepo. This came about for several reasons with a common theme
of convenience, namely, having a monorepo:

cleans up the problem of dependencies (as we have seen first
hand with dependabot enabled, it can cause some grief)
completely removes the problem of syncing the closely dependent
repos (e.g., updating wasi-common with say a bugfix generally
implies creating a "sync" commit for pulling in the changes
into the "parent" repo, in this case, wasmtime; similar case
would happen for wasi-misc-tests vs wasi-common scenario)
mainly for the two reasons above, makes publishing to
crates.io easier
hopefully streamlines the process of getting the community involved
in contributing tests to wasi-common as now everything is one
place

Additionally, while here, this commit also updates the dependencies and
cleans up Cargo.toml with details such as authors, etc.

These wrappers handle converting from &str to pointer+length and handle unsafe.

Ensure that clearing __WASI_RIGHT_PATH_FILESTAT_SET_SIZE succeeds before testing file truncation.

Modularise tests for easier use with wasi-common crate

Fix typo

* nofollow_errors now operators on symlinks to existing resources * dangling_symlink covers danling symlinks tests

* Enable Actions and add rust.yml This commit enables Github Actions and adds corresponding configuration in rust.yml file. * Update rust.yml * Fix formatting * Add empty .rustfmt.toml config file

@dunnock

* Add test case for `poll_oneoff` syscall This commit adds a test case for `poll_oneoff` syscall. In particular, it builds on the excellent test use case provided by @dunnock in their repo [poll_oneoff_tests] (thanks!), and tests: * simple timeout * stdin read with timeout * fd read and fd write polls [poll_oneoff_tests]: https://github.com/dunnock/poll_oneoff_tests * Apply suggestions and negative test for bad fd Co-authored-by: Maxim Vorobjov <maxim.vorobjov@gmail.com> * Add smoke test for STDOUT/ERR readwrite poll * Add comment on stdin/out/err

… is not a dir.

This commit merges [CraneStation/wasi-misc-tests] repo as a subdir of this repo while preserving **all** of git history. There is an initiative to pull `wasi-common` and `wasi-misc-tests` into [CraneStation/wasmtime], and [CraneStation/wasmtime] becoming a monorepo. This came about for several reasons with a common theme of convenience, namely, having a monorepo: 1. cleans up the problem of dependencies (as we have seen first hand with dependabot enabled, it can cause some grief) 2. completely removes the problem of syncing the closely dependent repos (e.g., updating wasi-common with say a bugfix generally implies creating a "sync" commit for pulling in the changes into the "parent" repo, in this case, `wasmtime`; similar case would happen for `wasi-misc-tests` vs `wasi-common` scenario) 3. mainly for the two reasons above, makes publishing to crates.io easier 4. hopefully streamlines the process of getting the community involved in contributing tests to `wasi-common` as now everything is one place [CraneStation/wasi-misc-tests]: https://github.com/CraneStation/wasi-misc-tests [CraneStation/wasmtime]: https://github.com/CraneStation/wasmtime Additionally, while here, this commit also updates the dependencies and cleans up `Cargo.toml` with details such as authors, etc.

marmistrz

I'm definitely in favor of merging those two repos!

marmistrz · 2019-11-06T17:03:10Z

wasi-misc-tests/LICENSE

@@ -0,0 +1,220 @@
+


Do we need a separate license here?

We'd need one if the crate would be published on crates.io, but I don't think we mean to do that for now, so we can omit the LICENSE if you want.

Removed! We can re-add it later when and if we decide to publish wasi-misc-tests as a crate. :-)

peterhuene

👍. I also think we can forego the additional LICENSE file, but this looks great. Thanks!

marmistrz · 2019-11-06T19:55:05Z

@kubkon could we merge #116 first?

sunfishcode · 2019-11-06T20:00:20Z

wasi-misc-tests/Cargo.toml

+name = "wasi-misc-tests"
+version = "0.1.0"
+authors = ["The Wasmtime Project Developers"]
+edition = "2018"


We should add 'publish = false' here since this isn't meant to be published on crates.io in its current form.

kubkon · 2019-11-07T10:29:57Z

@kubkon could we merge #116 first?

Absolutely, that's the plan :-) In fact, I'll wait with this PR until #175 is also merged to avoid hellish rebases.

sunfishcode and others added 30 commits April 23, 2019 15:59

Initial checkin.

f3a20a4

Update to rust-lang libc.

7664f52

Add a .gitignore file.

113aaab

Factor out functions for cleaning up files and directories.

91626bb

Fix a typo in a comment.

eecf3ce

Print a "Success!" message if all tests passed.

2eef281

Factor out code for creating directories.

97db79c

Add wrappers around WASI functions.

4908736

These wrappers handle converting from &str to pointer+length and handle unsafe.

More refactoring.

64ae704

Refactor a fd_close helper.

a9a5d12

Move utility functions into a separate file.

87ab53a

cargo update

472bc78

Add a basic test for random_get.

ab3ab21

Test that directories aren't resizable.

739600b

Test clearing __WASI_RIGHT_PATH_FILESTAT_SET_SIZE.

113b0bf

Ensure that clearing __WASI_RIGHT_PATH_FILESTAT_SET_SIZE succeeds before testing file truncation.

cargo update

9ed89c0

Modularise tests for easier use with wasi-common crate

108c2de

Merge pull request #1 from kubkon/modularize

5c5b419

Modularise tests for easier use with wasi-common crate

Add a Code of Conduct and CONTRIBUTING.md.

bfce697

Fix typo

1ec5550

Merge pull request #2 from kubkon/fix-typo

9f5a558

Fix typo

Add testcase for fd_allocate

9f8c648

Add positive test for fd_renumber

f31d5d4

Assert bufused in readlink_no_buffer testcase

2c67c17

Add positive readlink testcase

c3b194f

Add testcase for fd_seek and fd_tell

fe23313

Add fd_p{read, write} test

35222cb

Add README

eede5ed

Add cases with trailing slashes to interesting_paths

ddc73e5

Split nofollow_errors testcase into two

796770d

* nofollow_errors now operators on symlinks to existing resources * dangling_symlink covers danling symlinks tests

kubkon and others added 8 commits October 23, 2019 16:49

Fix compilation error

2a0c524

Enable Actions and add rust.yml (#35)

4f0b760

* Enable Actions and add rust.yml This commit enables Github Actions and adds corresponding configuration in rust.yml file. * Update rust.yml * Fix formatting * Add empty .rustfmt.toml config file

Add badge to README

1a510a1

Update README

7094c55

Clean up Github Actions and README

8c712f3

Add a test for *at-style functions returning ENOTDIR when dirfd…

f677228

… is not a dir.

Remove misc_testsuite submodule

339b0fa

kubkon force-pushed the merge_misc_testsuite branch 5 times, most recently from 340defd to 1cb2bfc Compare November 6, 2019 15:33

kubkon force-pushed the merge_misc_testsuite branch from 1cb2bfc to 36d8155 Compare November 6, 2019 15:38

Merge branch 'master' into merge_misc_testsuite

caf16a1

kubkon marked this pull request as ready for review November 6, 2019 16:24

kubkon requested review from marmistrz, sunfishcode, pchickey and peterhuene November 6, 2019 16:24

marmistrz approved these changes Nov 6, 2019

View reviewed changes

peterhuene approved these changes Nov 6, 2019

View reviewed changes

sunfishcode reviewed Nov 6, 2019

View reviewed changes

Add "publish=false" to Cargo.toml; remove LICENSE

e9d08a4

kubkon mentioned this pull request Nov 7, 2019

Improvements to WasiCtxBuilder, and a couple bug fixes #175

Merged

Merge branch 'master' into merge_misc_testsuite

b4d35c5

kubkon merged commit 3793fa3 into master Nov 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge wasi-misc-tests repo as a subdir #174

Merge wasi-misc-tests repo as a subdir #174

Uh oh!

kubkon commented Nov 6, 2019 •

edited

Loading

Uh oh!

marmistrz left a comment

Uh oh!

marmistrz Nov 6, 2019

Uh oh!

sunfishcode Nov 6, 2019

Uh oh!

kubkon Nov 7, 2019 •

edited

Loading

Uh oh!

peterhuene left a comment

Uh oh!

marmistrz commented Nov 6, 2019 •

edited

Loading

Uh oh!

sunfishcode Nov 6, 2019

Uh oh!

kubkon commented Nov 7, 2019

Uh oh!

Uh oh!

Merge wasi-misc-tests repo as a subdir #174

Merge wasi-misc-tests repo as a subdir #174

Uh oh!

Conversation

kubkon commented Nov 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marmistrz left a comment

Choose a reason for hiding this comment

Uh oh!

marmistrz Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

sunfishcode Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

kubkon Nov 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peterhuene left a comment

Choose a reason for hiding this comment

Uh oh!

marmistrz commented Nov 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sunfishcode Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

kubkon commented Nov 7, 2019

Uh oh!

Uh oh!

kubkon commented Nov 6, 2019 •

edited

Loading

kubkon Nov 7, 2019 •

edited

Loading

marmistrz commented Nov 6, 2019 •

edited

Loading