Skip to content

Conversation

juliaputko
Copy link
Contributor

No description provided.

Copy link
Contributor

@amandarichardsonn amandarichardsonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 18.45103% with 358 lines in your changes missing coverage. Please review.

Please upload report for BASE (smartsim-refactor@f21b6f8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/_core/control/controller.py 8.18% 101 Missing ⚠️
smartsim/_core/launcher/colocated.py 6.25% 45 Missing ⚠️
smartsim/database/orchestrator.py 15.09% 45 Missing ⚠️
smartsim/entity/model.py 23.80% 32 Missing ⚠️
smartsim/_core/control/jobmanager.py 15.38% 22 Missing ⚠️
smartsim/experiment.py 15.78% 16 Missing ⚠️
smartsim/_core/control/manifest.py 40.00% 12 Missing ⚠️
smartsim/_core/utils/redis.py 25.00% 12 Missing ⚠️
smartsim/entity/ensemble.py 20.00% 12 Missing ⚠️
smartsim/_core/utils/telemetry/collector.py 11.11% 8 Missing ⚠️
... and 17 more
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             smartsim-refactor     #597   +/-   ##
====================================================
  Coverage                     ?   30.70%           
====================================================
  Files                        ?       78           
  Lines                        ?     6005           
  Branches                     ?        0           
====================================================
  Hits                         ?     1844           
  Misses                       ?     4161           
  Partials                     ?        0           
Files with missing lines Coverage Δ
smartsim/_core/utils/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/utils/telemetry/util.py 32.35% <ø> (ø)
smartsim/database/__init__.py 100.00% <100.00%> (ø)
smartsim/entity/__init__.py 100.00% <100.00%> (ø)
smartsim/error/errors.py 58.33% <100.00%> (ø)
smartsim/ml/data.py 30.67% <ø> (ø)
smartsim/ml/tf/utils.py 26.92% <ø> (ø)
smartsim/_core/control/previewrenderer.py 41.17% <0.00%> (ø)
smartsim/_core/launcher/step/dragonStep.py 37.09% <0.00%> (ø)
smartsim/_core/launcher/step/localStep.py 35.00% <66.66%> (ø)
... and 24 more

@juliaputko juliaputko merged commit 883824b into CrayLabs:smartsim-refactor Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants