Refine SmartSimEntity Interface #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #688 +/- ##
=====================================================
+ Coverage 40.45% 43.36% +2.90%
=====================================================
Files 110 110
Lines 7326 7042 -284
=====================================================
+ Hits 2964 3054 +90
+ Misses 4362 3988 -374
|
MattToast
requested changes
Aug 29, 2024
mellis13
reviewed
Aug 29, 2024
smartsim/_core/control/job.py
Outdated
| @@ -299,7 +299,7 @@ def error_report(self) -> str: | |||
| warning += f"Job status at failure: {self.status} \n" | |||
| warning += f"Launcher status at failure: {self.raw_status} \n" | |||
| warning += f"Job returncode: {self.returncode} \n" | |||
| warning += f"Error and output file located at: {self.entity.path}" | |||
| # warning += f"Error and output file located at: {self.job.path}" | |||
There was a problem hiding this comment.
Is this commented out because it wrong or because it just won't work?
There was a problem hiding this comment.
Path is no longer on entity, for a second I thought I could access off of Job but no. I commented it out and left it incase we want to replace in the future, it will not be forgotten
MattToast
approved these changes
Aug 29, 2024
amandarichardsonn
merged commit 4a4f43a
into
CrayLabs:smartsim-refactor
34 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor SmartSimEntity class, remove ExecutableProtocol protocol, Application becomes subclass of ABC SmartSImEntity