Skip to content

Conversation

rickybalin
Copy link
Contributor

This PR adds the ability to turn off monitoring of Models launched with experiment.start() by modifying the Controller and JobManager classes. With this update, experiment.start() takes an additional boolean argument determining whether to monitor the particular model or not. The argument is set to True by default, so it should not require any changes for the default behavior of monitoring all Models launched.

The PR also adds a method to PalsMpiexecSettings called set_launcher_args() to be able to add any launcher arguments to the mpiexec command.

rickybalin and others added 22 commits October 28, 2022 14:05
…ded when sharing GPU between different applications running with the co-located database deployment.
Fully sync fork with the official SmartSim develop branch
@al-rigazzi al-rigazzi self-requested a review July 2, 2025 22:22
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.99%. Comparing base (d7d979e) to head (930ca5a).
⚠️ Report is 20 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #788       +/-   ##
============================================
- Coverage    83.91%   52.99%   -30.92%     
============================================
  Files           83       84        +1     
  Lines         6284     7016      +732     
============================================
- Hits          5273     3718     -1555     
- Misses        1011     3298     +2287     
Files with missing lines Coverage Δ
smartsim/_core/control/controller.py 67.56% <100.00%> (-17.67%) ⬇️
smartsim/_core/control/jobmanager.py 76.39% <100.00%> (-17.76%) ⬇️
smartsim/_core/control/manifest.py 72.61% <ø> (-23.31%) ⬇️
smartsim/experiment.py 64.67% <ø> (-21.20%) ⬇️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants