-
Notifications
You must be signed in to change notification settings - Fork 37
Add functionality to turn off monitoring status of Models launched #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rickybalin
wants to merge
27
commits into
CrayLabs:develop
Choose a base branch
from
rickybalin:feature/monitor_model
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded when sharing GPU between different applications running with the co-located database deployment.
…std17 standard for Torch
Fully sync fork with the official SmartSim develop branch
…nitor and which to not
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #788 +/- ##
============================================
- Coverage 83.91% 52.99% -30.92%
============================================
Files 83 84 +1
Lines 6284 7016 +732
============================================
- Hits 5273 3718 -1555
- Misses 1011 3298 +2287
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to turn off monitoring of Models launched with
experiment.start()
by modifying the Controller and JobManager classes. With this update,experiment.start()
takes an additional boolean argument determining whether to monitor the particular model or not. The argument is set toTrue
by default, so it should not require any changes for the default behavior of monitoring all Models launched.The PR also adds a method to
PalsMpiexecSettings
calledset_launcher_args()
to be able to add any launcher arguments to the mpiexec command.