Add extra log when status code is not defined.

[konradkar2]

This refers to #430

Just to document behaviour when returning a status that is not well-known.
This issue could be fixed in a better way in the future, because for know it is only observed when using actual TCP connection -
simple UT that uses app.handle(req, res) will return user defined status code.

Added some extra check on UT that caused segfault on my pc.

[crow-clang-format]

--- include/crow/http_connection.h	(before formatting)
+++ include/crow/http_connection.h	(after formatting)
@@ -318,7 +318,9 @@
 
             if (!statusCodes.count(res.code))
             {
-                CROW_LOG_WARNING << this << " status code " << "(" << res.code << ")" << " not defined, returning 500 instead";
+                CROW_LOG_WARNING << this << " status code "
+                                 << "(" << res.code << ")"
+                                 << " not defined, returning 500 instead";
                 res.code = 500;
             }
 
--- tests/unittest.cpp	(before formatting)
+++ tests/unittest.cpp	(after formatting)
@@ -577,7 +577,6 @@
     SimpleApp app;
     CROW_ROUTE(app, "/get123")
     ([] {
-
         //this status does not exists statusCodes map defined in include/crow/http_connection.h
         const int undefinedStatusCode = 123;
         return response(undefinedStatusCode, "this should return 500");
@@ -592,8 +591,7 @@
     app.wait_for_server_start();
 
     asio::io_service is;
-    auto sendRequestAndGetStatusCode = [&is](const std::string & route) -> unsigned
-    {
+    auto sendRequestAndGetStatusCode = [&is](const std::string& route) -> unsigned {
         asio::ip::tcp::socket socket(is);
         socket.connect(asio::ip::tcp::endpoint(asio::ip::address::from_string("127.0.0.1"), 45451));
 

[The-EDev]

Aside from the comments and code formatting, it would be interesting to have some form of compile time check and warning for an unknown status code. Do you know if this is possible?

[konradkar2]

Aside from the comments and code formatting, it would be interesting to have some form of compile time check and warning for an unknown status code. Do you know if this is possible?

Well I think this is a bigger change, what do you think about merging this one, and then the proper implementation could be added as different feature (reverting this one I guess).

[The-EDev]

Well I think this is a bigger change, what do you think about merging this one, and then the proper implementation could be added as different feature (reverting this one I guess).

Yeah I agree with you, I'm just wondering if it was possible, since I couldn't find much info on doing it online.

[konradkar2]

Well I think this is a bigger change, what do you think about merging this one, and then the proper implementation could be added as different feature (reverting this one I guess).

Yeah I agree with you, I'm just wondering if it was possible, since I couldn't find much info on doing it online.

Well the problem with compile time check is that if we do it in crow::response then it will become hard to create response in runtime, or even make it impossible.

[konradkar2]

Btw. why are we using "45451" as a port number in UTs? I've checked and port(0) results in random port, which is more robust I guess.

[The-EDev]

It's more of a tradition, getting the app's port and setting the port to 0 were recent additions to crow (post v0.3). so the tests needed a port that was most likely not used and is predictable.

[The-EDev]

Please replace REQUIRE with CHECK and an if statement in the unit tests, as a failing REQUIRE would prevent other tests from running.

Also CI seems to be exceeding the time limit (seems like some sort of blocking function / infinite loop)