Use const std::string& as argument to route()
#684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschreib
changed the title
route()const std::string& as argument to route()
gittiver
approved these changes
Jan 29, 2024
gittiver
added a commit
that referenced
this pull request
Feb 21, 2024
* master: fix: call after_handlers for legitimate requests without body part Handle _CROW_ILL or _CROW_ICD being NOTFOUND small explanations in the example on using CORS middleware in Crow v1.0 Use const std::string& as argument to route() (#684) fix: minimize the precision loss when dumping double to string (#712) package format changed to zip, version set to >1.1.0 (first release) Fix #754 (#755)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671.
NB: I went for
const std::string&rather thanstd::string + std::move()for simplicity. Performance-wise it may not even be a loss;std::stringisn't extremely cheap to move because of small-string optimisation (e.g.,sizeof(std::string)is 32 bytes with libstdc++). Nevertheless, route creation is unlikely to be a performance bottleneck, so performance probably does not matter and the simplest solution will be the best. If performance did matter, then the ideal solution would probably involvestd::string_view(C++17). With a bit of work we could also usecrow::black_magic::const_strfromutility.h, which is similar tostd::string_view, but again I don't think this is worth the complication.