Skip to content

fix: VulnerabilityScoreSource.get_from_vector() for CVSS_V3_1 and CVSS_V4 #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 10, 2025
Merged

fix: VulnerabilityScoreSource.get_from_vector() for CVSS_V3_1 and CVSS_V4 #824

merged 10 commits into from
Jun 10, 2025

Conversation

jkowalleck
Copy link
Member

fixes #821

@jkowalleck
tests
3c48d27 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from a team as a code owner June 9, 2025 09:08
@jkowalleck jkowalleck added the bug Something isn't working label Jun 9, 2025
@jkowalleck jkowalleck marked this pull request as draft June 9, 2025 09:08
@jkowalleck
wip
926c4b0 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@codacy-production Codacy Production
Copy link

codacy-production bot commented Jun 9, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -0.13% ✅ 93.75% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (41b2d25) 5203 4875 93.70%
Head commit (0efbf0a) 5610 (+407) 5249 (+374) 93.57% (-0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#824) 16 15 93.75%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@jkowalleck
wip
786f09f 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title fix: VulnerabilityScoreSource.get_from_vector vor CVSS_V3_1 and CVSS_V4 [WIP] fix: VulnerabilityScoreSource.get_from_vector vor CVSS_V3_1 and CVSS_V4 Jun 9, 2025
@jkowalleck jkowalleck changed the title [WIP] fix: VulnerabilityScoreSource.get_from_vector vor CVSS_V3_1 and CVSS_V4 [WIP] fix: VulnerabilityScoreSource.get_from_vector() vor CVSS_V3_1 and CVSS_V4 Jun 9, 2025
@jkowalleck jkowalleck changed the title [WIP] fix: VulnerabilityScoreSource.get_from_vector() vor CVSS_V3_1 and CVSS_V4 [WIP] fix: VulnerabilityScoreSource.get_from_vector() for CVSS_V3_1 and CVSS_V4 Jun 9, 2025
jkowalleck added 4 commits June 9, 2025 11:43
@jkowalleck
wip
b4f1273 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
e477a86 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
128b25d 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
21aeb75 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck mentioned this pull request Jun 9, 2025
Closed
@jkowalleck jkowalleck marked this pull request as ready for review June 9, 2025 09:53
jkowalleck added 3 commits June 9, 2025 12:00
@jkowalleck
wip
e204726 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
63b6305 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
0efbf0a 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title [WIP] fix: VulnerabilityScoreSource.get_from_vector() for CVSS_V3_1 and CVSS_V4 fix: VulnerabilityScoreSource.get_from_vector() for CVSS_V3_1 and CVSS_V4 Jun 9, 2025
@jkowalleck jkowalleck merged commit a97ccd4 into main Jun 10, 2025
47 checks passed
@jkowalleck
Copy link
Member Author

this fix was released in https://github.com/CycloneDX/cyclonedx-python-lib/releases/tag/v10.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VulnerabilityScoreSource.get_from_vector() does not return CVSS_V3_1 and CVSS_V4
1 participant
@jkowalleck