List indexing polygon conversion #915
Open
+83
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| break; | ||
| } | ||
| default: | ||
| assert(false); |
There was a problem hiding this comment.
needs a return nullptr after
There was a problem hiding this comment.
cause non-Debug builds will never assert
|
Rember to build or Use CI to check before labelling things as merge ready (also whenever you actually have a test/example run it cause CI doesn't run tests yet - just checks buildability). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a method in polygon manipulator that turn any non triangle list geometry to triangle list geometry.