Pm mypackages - update package version #14655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now all colors are controlled by the COLORS object in confing.js
- correctly creates minimum depth folder structure for the files added
- updated browser to only show root items
- added pages for the wizard-like experience when publishing a package
- using Dispatcher fixes the async tree creation
- tests added to assert correct functionality of collecting files and folders
- updated files and folders icons - now only allows LibraryNode checkboxes for Assembly dll files
- started the structure for preview build
- added tests for the core methods of PreviewPackageBuild
- changed `RemoveItem` method to account for folder items being removed - fixed a bug where removing an Assembly file would generate an error. Assembly files can also be added to 'additional items'
- UI added to allow users to add/remove items from current Package selection
- ui tweaks
- preview contents now correctly display based on user choice (retain folder or not) - fixed a bug where CustomDefinitions would read as root item - Pages are disabled when not displayed, in order to stop handling of tasks that affect other Pages
- now sorts browser alphabetically - fixed disabled behavior
- assemblies now will show up with their file path, but still get picked up from their assembly resource on disk
- we need the ability to display custom nodes as file with file paths during package creation. CustomDefinition does not have the attributes to address that, so we are adding a new 'preview' item type to server the purpose
- added tests for delete item - fixed an issue where removing all items would not result in cleaning the RootContent items - added detailed description for the customTreeView_SelectedItemChanged method
- fixed checkbox behavior to be consistent when interacting with the rest of the controls
- clearing data and ui after publishing - clearing data and ui with Cancel button
- finished the main flow between the pages
- publish local retaining folder structure
- now warns the user of losing changes if using cancel or navigating away
- also clear custom definition filepaths
…-packagecontents-revert
- disabled this test for the moment, it contaminates the packages folder by creating a package and leading to numerous failure tests consequently
- fixed a bug where the install to folder would not show the required dialog - fixed a bug where after locking the name for edit (after submitting a new package version) clearing the results would not remove the block from typing the name
commit f5d5563 Author: Deyan Nenov <dnenov@archilizer.com> Date: Tue Nov 28 12:12:19 2023 +0000 dispose methods null checks - trying to prevent null exceptions in case resources have been cleared before dispose event has been called commit e43ad53 Author: Deyan Nenov <dnenov@archilizer.com> Date: Tue Nov 28 11:05:20 2023 +0000 remove begin invoke from mainFrame_Navigated - this was done to try and fix a failing test but it should not be needed commit 42bf04c Author: Deyan Nenov <dnenov@archilizer.com> Date: Mon Nov 27 21:04:19 2023 +0000 null check to mainFrame_Navigated - added a null check commit 9dde030 Merge: a77a11a 3f765b5 Author: Deyan Nenov <dnenov@archilizer.com> Date: Mon Nov 27 18:07:39 2023 +0000 Merge branch 'pm-publishpackage-cherrypick-resources' into pm-publishpackage-cherrypick-mypackage commit a77a11a Author: Deyan Nenov <dnenov@archilizer.com> Date: Mon Nov 27 17:47:17 2023 +0000 main changes - this cherry-pick contains all main changes minus resources and tests. - will need to merge resources to work correctly - if this breaks the test run, we will need to further split it up, or introduce the changes one by one somehow commit 3f765b5 Merge: 95d502a 36fb8d3 Author: Deyan Nenov <dnenov@archilizer.com> Date: Mon Nov 27 17:38:11 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-cherrypick-resources commit 95d502a Author: Deyan Nenov <dnenov@archilizer.com> Date: Mon Nov 27 17:38:02 2023 +0000 resource cherry-pick - picked up all resource changes commit 36fb8d3 Author: Jorgen Dahl <sm6srw@users.noreply.github.com> Date: Mon Nov 27 11:51:35 2023 -0500 Test net8 (DynamoDS#14635) * Test net8 * Also add DotNet to the build properties * Update CS_SDK.props * Update CS_SDK.props * update * update * update * Go back to net6 --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> commit cbba6d0 Author: Michael Kirschner <mjk.kirschner@gmail.com> Date: Mon Nov 27 11:26:04 2023 -0500 DYN-6412 fix performance issue with feature flags, and deadlock with CLI wrapper. (DynamoDS#14637) * fix for null data being shown over and over * fix issues with cli wrapper get data * revert * add test * review comments add tests * comments * review comments commit c5df6f9 Author: Ashish Aggarwal <ashish.aggarwal@autodesk.com> Date: Mon Nov 27 11:22:32 2023 -0500 Replace Application.Current with HostAnalyticsInfo.HostName check (DynamoDS#14574) * Fix PostDiff job * replace application.current * tests * refactor after Bogdans PR --------- Co-authored-by: Aaron (Qilong) <173288704@qq.com> commit 11b1f7c Author: jesusalvino <96534278+jesusalvino@users.noreply.github.com> Date: Mon Nov 27 08:55:32 2023 -0500 DYN-6313 Add ML Node AutoComplete TOU (DynamoDS#14625) * Updating the Agreement and Term of Use * Adding the MLNodeAuntocomplete rtf file * Persists the AgreeToMLAutocompleteTOU as preference settings * rename property * resources and control names * Clean up * Update * update --------- Co-authored-by: Jesus Alfredo Alviño <jesus.alfredo.alvino@autodesk.com> Co-authored-by: Aaron (Qilong) <aaron.tang@autodesk.com> commit 3e97cbd Author: Aabishkar KC <aabishkar@gmail.com> Date: Wed Nov 22 12:56:04 2023 -0500 Update smoke tests workflow (DynamoDS#14638)
- fixed a small issue where the selected known hosts were not being cleared on reset
9 tasks
- moved small fixes to publish package name validation to this branch
|
@dnenov Installed Packages text still dramatically smaller than the rest of this UI - is this addressed in a different PR? Beyond that this looks great! |
reddyashish
reviewed
Dec 1, 2023
reddyashish
reviewed
Dec 1, 2023
src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerPublishControl.xaml.cs
Outdated
Show resolved
Hide resolved
reddyashish
reviewed
Dec 1, 2023
There was a problem hiding this comment.
LGTM with one comment.
Running the self-serve job here: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1311/
reddyashish
pushed a commit
that referenced
this pull request
Dec 5, 2023
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted here - #14689
Cherry-pick UI - #14655
Purpose
A final edition to the package manager updates focusing on publishing a new version of the existing package. Based on #14645.
installed packagestabmy packagestab where the 'Install' button will turn into a 'publish version' buttonUI Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
@reddyashish
FYIs
@Amoursol