DYN-8615 OpenXML Excel Exception #16185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably this error is based in how the excel spreadsheet was created but basically the problem is that when the spreadsheet contains empty rows sometimes the LastChild is null so the "Object reference not set to an instance of an object." exception is generated when trying to check any property inside the Cell instance. For fixing this problem I just added a validation that will skip the empty row if Row.LastChild is null.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8615
|
GIF created AFTER my fix |
|
GIF created BEFORE my fix |
|
@zeusongit any comment about this change? |
zeusongit
approved these changes
May 5, 2025
|
/cherrypick |
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2025
(cherry picked from commit f3cad63)
9 tasks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing problem with the Data.OpenXMLImportExcel node sending the exception "Object reference not set to an instance of an object.".
Probably this error is based in how the excel spreadsheet was created (by some reason is counting empty rows as if they contains data but if you copy the info to a new excel sheet it works as expected) but basically the problem is that when the spreadsheet contains empty rows sometimes the Row.LastChild is null so the "Object reference not set to an instance of an object." exception is generated when trying to check any property inside the Cell instance. For fixing this problem I just added a validation that will skip the empty row if Row.LastChild is null.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing problem with the Data.OpenXMLImportExcel node sending the exception "Object reference not set to an instance of an object.".
Reviewers
@zeusongit @DynamoDS/eidos
FYIs
@achintyabhat