Skip to content

DYN-9112: Hide DNA result until layout is figured out. #16349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

chubakueno
Copy link
Contributor

Purpose

Hide DNA result until layout is figured out. Related to #16188

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Hide DNA result until layout is figured out.

Reviewers

@johnpierson
@BogdanZavu

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9112

@chubakueno chubakueno requested a review from saintentropy July 7, 2025 22:36
@QilongTang QilongTang requested a review from Copilot July 8, 2025 00:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds logic to hide the DNA result node until its layout is finalized by binding the IsHidden property to the control’s Visibility.

  • Introduces an InverseBoolToVisibilityConverter instance and applies a binding in code-behind.
  • Updates the XAML root to self-close the UserControl after removing a commented-out binding.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
NodeView.xaml.cs Added static converter instance and bound Visibility to IsHidden.
NodeView.xaml Converted root <UserControl> to self-closing, removing commented lines.
Comments suppressed due to low confidence (2)

src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs:267

  • [nitpick] Field name _inverseBooleanToVisibilityConverter doesn’t match the type InverseBoolToVisibilityConverter. Consider renaming the field to _inverseBoolToVisibilityConverter for consistency.
        private static InverseBoolToVisibilityConverter _inverseBooleanToVisibilityConverter = new InverseBoolToVisibilityConverter();

src/DynamoCoreWpf/Views/Core/NodeView.xaml:13

  • The self-closing <UserControl> tag removes all child elements and content. It looks unintentional—restore the original closing tag and preserve the inner view markup.
             PreviewMouseMove="OnNodeViewMouseMove"/>

@chubakueno chubakueno merged commit 1049bae into DynamoDS:master Jul 8, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants