Skip to content

Support DraftRetriever datastore read/write for large vocab sizes (i.e. llama3+) and REST inference for llama3 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

scandukuri
Copy link

@scandukuri scandukuri commented Nov 20, 2024

Here we make the necessary changes to read and write suffixes to memory and file for large tokenizers; the original implementation only supported token IDs up to Rust u16::MAX (65,535). Crucially, using Rust i32 for reading and writing individual token IDs (instead of u16 originally) allows the tool to support token IDs of up to Rust i32::MAX (2,147,483,647), and still allows negative placeholder IDs for padding in the implementation like -2.

We also make the necessary adjustments torest/modeling_llama_kv.py to support llama3 inference with REST, adapted from the transformers implementation. Importantly, we need to repeat_kv for new keys and values before concatenating them to cached keys and values, in order to avoid shape mismatches (by only adding a single query group to all cached keys and values).

Including the old PR here for reference. Thanks! 🦙

@scandukuri
Copy link
Author

@zhenyuhe00 Here's a new PR with a separate branch and added changes to modeling_llama_kv.py - it seems like the base branch may still be main, though. Do you know how I can PR my fork's llama3 changes to create a new llama3 branch in the original codebase?

@zhenyuhe00
Copy link
Collaborator

Hi, I appreciate your effort! Since the repository only has the "main" branch, I added a new branch called "llama3" just now. It could be merged into the "llama3" branch.

@zhenyuhe00 zhenyuhe00 changed the base branch from main to llama3 November 22, 2024 03:21
@zhenyuhe00 zhenyuhe00 merged commit ff9d5e4 into FasterDecoding:llama3 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants