feat: v4.0.0 - clean up session ID requirement changes #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2025
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
turnervink-finch
force-pushed
the
08-14-split_up_init_and_open_args
branch
3 times, most recently
from
7b3b697 to
a403c1f
Compare
turnervink-finch
changed the title
turnervink-finch
requested review from
a team,
aneeshvaidya and
Francisco-Donadio
turnervink-finch
force-pushed
the
08-14-split_up_init_and_open_args
branch
from
a403c1f to
9b090bc
Compare
| ...(sendState ? { state: new Date().toISOString() } : undefined), | ||
| }) | ||
| // Generate a session ID using the /connect/sessions endpoint on the Finch API | ||
| // See the docs here https://developer.tryfinch.com/api-reference/connect/new-session#create-a-new-connect-session |
There was a problem hiding this comment.
praise(): i like adding the docs link here 🚀
turnervink-finch
force-pushed
the
08-14-split_up_init_and_open_args
branch
from
9b090bc to
a66ad2f
Compare
ashwin-finch
approved these changes
Aug 15, 2025
turnervink-finch
force-pushed
the
08-14-split_up_init_and_open_args
branch
2 times, most recently
from
4514d2a to
124b7cf
Compare
turnervink-finch
force-pushed
the
08-14-remove_support_for_not_providing_a_session_id
branch
from
a447ebb to
25afa12
Compare
Base automatically changed from
08-14-remove_support_for_not_providing_a_session_id
to
main
August 15, 2025 21:16
turnervink-finch
force-pushed
the
08-14-split_up_init_and_open_args
branch
from
124b7cf to
7104df9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the major version to v4.0.0 and cleans up the changes that dropped support for static Connect.
The initialize call now takes in the callbacks and optional override for the base URL. The base URL override is not documented as it is an internal feature that customers will not have a use for.
The open call now takes in the session ID and optional state and z-index value.
All values are loaded from the provided session with no ability to override them.
Testing