Integrate 10.3 Consensus queries #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasagredo> you need to recreate the golden files, to check the changes to the RECREATE_GOLDEN_FILES=1 cabal test cardano-cli-goldenand then commit the changes, after verifying them. |
|
Other than that LGTM so far 👍 |
jasagredo
force-pushed
the
js/10-3-queries
branch
from
21cc3ca to
198985f
Compare
jasagredo
requested review from
Jimbo4350,
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
|
@jasagredo> I updated the golden files. There are changes to the golden files of |
|
Did I do so in my branch? I'm based off Aniket's release branch so maybe it was modified there? |
|
@jasagredo> I did so in this PR's branch:
|
aniketd
force-pushed
the
aniketd/release-10-3
branch
from
9006b84 to
98918f8
Compare
aniketd
force-pushed
the
js/10-3-queries
branch
from
58c5daf to
3fda154
Compare
Jimbo4350
approved these changes
Mar 28, 2025
aniketd
force-pushed
the
js/10-3-queries
branch
from
8718df9 to
4e91acb
Compare
aniketd
force-pushed
the
aniketd/release-10-3
branch
from
b01821a to
e9e0d01
Compare
aniketd
force-pushed
the
js/10-3-queries
branch
from
4e91acb to
79502ea
Compare
carbolymer
reviewed
Mar 31, 2025
carbolymer
approved these changes
Mar 31, 2025
aniketd
force-pushed
the
aniketd/release-10-3
branch
2 times, most recently
from
3812894 to
6e62c0b
Compare
aniketd
force-pushed
the
js/10-3-queries
branch
from
79502ea to
c85b1ce
Compare
carbolymer
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist