Restore configurability of traces

[deepfire]

Restore configurability that a number of traces had lost:

• ChainDB
• DnsSubscription
• BlockFetchDecision
• ForgeState
• Forge
• Mempool

Add configurability for the BlockchainTime trace (off by default).

[CodiePP]

the function tracerOnOff has hardcoded "MinimalVerbosity" and is not taking into account the verbosity level as set in the configuration (line 908 of Tracers.hs)
would it be possible to also pass in the TracingVerbosity to this function?

[deepfire]

the function tracerOnOff has hardcoded "MinimalVerbosity" and is not taking into account the verbosity level as set in the configuration (line 908 of Tracers.hs)
would it be possible to also pass in the TracingVerbosity to this function?

Yes, that deviation of the original, obvious tracerOnOff semantic (which used to match its name) is very confusing and counterproductive.

I think that needs to be fixed, but it's probably out of scope for this PR.

cc @Jimbo4350

[deepfire]

bors r+

[Jimbo4350]

the function tracerOnOff has hardcoded "MinimalVerbosity" and is not taking into account the verbosity level as set in the configuration (line 908 of Tracers.hs)
would it be possible to also pass in the TracingVerbosity to this function?

Yes, that deviation of the original, obvious tracerOnOff semantic (which used to match its name) is very confusing and counterproductive.

I think that needs to be fixed, but it's probably out of scope for this PR.

cc @Jimbo4350

@deepfire
The current tracerOnOff mechanism will remain as is for now. The recent refactor has made things significantly clearer and we have more refactoring planned for this module. I have a branch that I will rebase on master, once this PR is merged, to fix the hardcoded trace verbosity issue.

[iohk-bors]

Build succeeded

• buildkite/cardano-node
• ci/hydra-eval
• ci/hydra-build:required