Return the error cases in runTxSubmit #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
requested review from
dcoutts,
erikd,
Jimbo4350 and
mrBliss
as code owners
intricate
force-pushed
the
intricate/1118-cli-exit-codes
branch
from
cbf015e to
0651ee5
Compare
intricate
commented
Jun 9, 2020
| TxSubmitFailureShelley err -> liftIO $ print err | ||
| TxSubmitSuccess -> return () | ||
| TxSubmitFailureShelley _ -> left (ShelleyTxSubmitError result) | ||
| TxSubmitFailureByron _ -> left (ShelleyTxSubmitError result) |
There was a problem hiding this comment.
Is it not odd that we're able to submit Byron transactions from this command?
There was a problem hiding this comment.
This should get sorted out as we flesh out the typed API
Jimbo4350
reviewed
Jun 9, 2020
| @@ -69,6 +70,8 @@ renderShelleyTxCmdError err = | |||
| "Error while writing signed shelley tx: " <> renderApiError apiError | |||
| ShelleyTxWriteUnsignedTxError apiError -> | |||
| "Error while writing unsigned shelley tx: " <> renderApiError apiError | |||
| ShelleyTxSubmitError txSubmitRes -> | |||
| "Error while submitting Shelley tx: " <> textShow txSubmitRes | |||
There was a problem hiding this comment.
We should write a renderTxSubmitError function here to provide more context with the errors vs just showing them.
Jimbo4350
approved these changes
Jun 10, 2020
dcoutts
approved these changes
Jun 10, 2020
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 10, 2020
1223: CAD-1135: Max Mempool size. r=dcoutts a=denisshevchenko Now maximum value of mempool (both txs size + txs number) aren't fixed, but it's based on real maximum values received from tracers. 1226: Return the error cases in runTxSubmit r=dcoutts a=intricate Closes #1118 1227: Yet more additions to the typed API r=dcoutts a=dcoutts Representations and serialisation for TxId, TxBody and Tx. Does not yet include round trip tests. 1229: Remove class HasTxMaxSize r=dcoutts a=dcoutts getMaxTxSize is no longer used as it has been replaced by maxTxSize from the LedgerSupportsMempool class. Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io> Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com> Co-authored-by: Duncan Coutts <duncan@well-typed.com>
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
bors merge |
|
Already running a review |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1118