Skip to content

Add a transaction txid cli command #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

Add a transaction txid cli command #1231

merged 1 commit into from
Jun 11, 2020

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented Jun 10, 2020

To get the txid of a tx body.

@dcoutts
Add a transaction txid cli command
d0858f3 
To get the txid of a tx body.
@dcoutts dcoutts requested review from Jimbo4350 and oneEdoubleD June 10, 2020 09:37
Jimbo4350
Jimbo4350 approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we also want to output the txid to a file?

oneEdoubleD
oneEdoubleD approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@oneEdoubleD oneEdoubleD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Returned a TxID when using it.

@intricate intricate linked an issue Jun 10, 2020 that may be closed by this pull request
[FR] - Get TxId from Tx #1230
Closed
@intricate
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 11, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 6724529 into master Jun 11, 2020
@iohk-bors iohk-bors bot deleted the dcoutts/cli-cmd-txid branch June 11, 2020 14:48
@dorin100 dorin100 mentioned this pull request Aug 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@erikd erikd Awaiting requested review from erikd

@mrBliss mrBliss Awaiting requested review from mrBliss

+2 more reviewers

@intricate intricate intricate approved these changes

@oneEdoubleD oneEdoubleD oneEdoubleD approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Get TxId from Tx
4 participants
@dcoutts @intricate @Jimbo4350 @oneEdoubleD