Implement ToObject instance for TraceTxSubmissionOutbound #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
force-pushed
the
intricate/527-3
branch
from
f2ee1f7 to
edac546
Compare
CodiePP
approved these changes
Mar 3, 2020
| [ "kind" .= String "TraceTxSubmissionOutboundRecvMsgRequestTxs" | ||
| , "txIds" .= String (pack $ show txids) | ||
| ] | ||
| toObject _verb (TraceTxSubmissionOutboundSendMsgReplyTxs txs) = |
There was a problem hiding this comment.
if the list of transactions can be large potentially, then it would make sense to only output the transactions ids for "MaximumVerbosity". Similarly, could the tx ids be shortened for "NormalVerbosity"?
This is more a thought than a review.
There was a problem hiding this comment.
At the moment, I believe we'll only see a max of 2 transactions per one of these traces. However, I've made the changes such that the txids and txs will only be output for MaximalVerbosity.
I'll also open an issue to revisit the verbosity-specific output for this instance (shortened txids, etc.).
intricate
force-pushed
the
intricate/527-3
branch
from
6eb270c to
9d11b96
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #527
See #584 (review)