Skip to content

CAD-721 expand TraceLabelPeer messages #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2020
Merged

CAD-721 expand TraceLabelPeer messages #663

merged 1 commit into from
Mar 11, 2020

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Mar 11, 2020 •
edited
Loading

Issue

  • TraceLabelPeer messages were abbreviated at level "NormalVerbosity". Now, they are fully shown in the logs.

  • This PR does not result in breaking changes to upstream dependencies.

Checklist

  • This PR contains all the work required to resolve the linked issue.

  • The work contained has sufficient documentation to describe what it does and how to do it.

  • The work has sufficient tests and/or testing.

  • I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

  • I have added the appropriate labels to this PR.

@CodiePP
CAD-721 expand TraceLabelPeer messages
9072020 
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
@CodiePP CodiePP added bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node. labels Mar 11, 2020
@CodiePP CodiePP added this to the S8 2020-03-12 milestone Mar 11, 2020
@CodiePP CodiePP self-assigned this Mar 11, 2020
@CodiePP CodiePP linked an issue Mar 11, 2020 that may be closed by this pull request
CAD-721 TraceLabelPeer messages are cluttering the log output #650
Closed
ArturWieczorek
ArturWieczorek approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@ArturWieczorek ArturWieczorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messages are expanded now:

[artur-de:cardano.node.BlockFetchDecision:Info:46] [2020-03-11 09:58:30.02 UTC] {"peer":"ConnectionId {localAddress = 192.168.1.100:35011, remoteAddress = 3.125.10.61:3001}","kind":"FetchDecision","decision":{"kind":"FetchDecision declined","declined":"FetchDeclineChainNotPlausible"}}
[artur-de:cardano.node.BlockFetchDecision:Info:46] [2020-03-11 09:58:30.22 UTC] {"peer":"ConnectionId {localAddress = 192.168.1.100:35011, remoteAddress = 3.125.10.61:3001}","kind":"FetchDecision","decision":{"kind":"FetchDecision declined","declined":"FetchDeclineChainNotPlausible"}}
[artur-de:cardano.node.BlockFetchDecision:Info:46] [2020-03-11 09:58:30.22 UTC] {"peer":"ConnectionId {localAddress = 192.168.1.100:35011, remoteAddress = 3.125.10.61:3001}","kind":"FetchDecision","decision":{"length":"2","kind":"FetchDecision results"}}
[artur-de:cardano.node.BlockFetchDecision:Info:46] [2020-03-11 09:58:30.22 UTC] {"peer":"ConnectionId {localAddress = 192.168.1.100:35011, remoteAddress = 3.125.10.61:3001}","kind":"FetchDecision","decision":{"length":"1","kind":"FetchDecision results"}}
[artur-de:cardano.node.BlockFetchDecision:Info:46] [2020-03-11 09:58:30.22 UTC]

@CodiePP
Copy link
Contributor Author

CodiePP commented Mar 11, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 11, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 0049a59 into master Mar 11, 2020
@iohk-bors iohk-bors bot deleted the cad-721-TraceLabelPeer-messages branch March 11, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturWieczorek ArturWieczorek ArturWieczorek approved these changes

@deepfire deepfire Awaiting requested review from deepfire

Assignees

@CodiePP CodiePP

Labels
bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CAD-721 TraceLabelPeer messages are cluttering the log output
2 participants
@CodiePP @ArturWieczorek