Documentation Updates #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
reviewed
Mar 13, 2020
scripts/SCRIPTS.md
Outdated
| ``` | ||
| ./scripts/submit-tx.sh generated-tx-file | ||
| ./scripts/submit-tx.sh my-transaction-name |
There was a problem hiding this comment.
If this arg is supposed to reference a file, I'd be clear about that here:
Suggested change
| ./scripts/submit-tx.sh my-transaction-name | |
| ./scripts/submit-tx.sh transaction-file |
scripts/SCRIPTS.md
Outdated
| ``` | ||
| The `submit-tx.sh` script by default sends the transaction to node with node id 0. | ||
|
|
||
| See cardano-cli's Transactions section for instructions on how to generate a tx. | ||
| See cardano-cli's [Transactions](../cardano-node/README.md) section for instructions on how to generate a tx. |
There was a problem hiding this comment.
You can link directly to that section:
Suggested change
| See cardano-cli's [Transactions](../cardano-node/README.md) section for instructions on how to generate a tx. | |
| See cardano-cli's [Transactions](../cardano-node/README.md#transactions) section for instructions on how to generate a tx. |
Jimbo4350
force-pushed
the
jordan/update-docs
branch
2 times, most recently
from
4b53490 to
28ea7bf
Compare
Jimbo4350
force-pushed
the
jordan/update-docs
branch
from
28ea7bf to
184795f
Compare
ArturWieczorek
approved these changes
Mar 20, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 20, 2020
677: Documentation Updates r=Jimbo4350 a=Jimbo4350 Issue ----------- - #620 - This PR **does not result** in breaking changes to upstream dependencies. Checklist --------- - [ ] This PR contains all the work required to resolve the linked issue. - [ ] The work contained has sufficient documentation to describe what it does and how to do it. - [ ] The work has sufficient tests and/or testing. - [ ] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these. - [ ] I have added the appropriate labels to this PR. Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Build failed |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Outdated development scripts and documentation #620
This PR does not result in breaking changes to upstream dependencies.
Checklist
This PR contains all the work required to resolve the linked issue.
The work contained has sufficient documentation to describe what it does and how to do it.
The work has sufficient tests and/or testing.
I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.
I have added the appropriate labels to this PR.