Skip to content

Implement byron vote creation and submission #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2020
Merged

Implement byron vote creation and submission #804

merged 2 commits into from
Apr 28, 2020

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Apr 15, 2020 •
edited
Loading

Issue

Checklist

  • This PR contains all the work required to resolve the linked issue.

  • The work contained has sufficient documentation to describe what it does and how to do it.

  • I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

  • I have added the appropriate labels to this PR.

@Jimbo4350 Jimbo4350 force-pushed the jordan/vote-creation-and-submission-3 branch 3 times, most recently from 68196de to fffdb16 Compare April 28, 2020 09:00
@Jimbo4350 Jimbo4350 marked this pull request as ready for review April 28, 2020 09:10
@Jimbo4350 Jimbo4350 added the shelley testnet issues/PRs that need to be done for the Shelley testnet label Apr 28, 2020
@Jimbo4350 Jimbo4350 force-pushed the jordan/vote-creation-and-submission-3 branch from fffdb16 to e9e70a9 Compare April 28, 2020 09:22
@Jimbo4350
Copy link
Contributor Author

I will update how the bryon commands are grouped and structured in a follow up PR so that QA and DevOps can begin to try out creation/submission of update proposals and votes.

ArturWieczorek
ArturWieczorek approved these changes Apr 28, 2020
View reviewed changes
README.md
@@ -333,7 +335,9 @@ You can also check your proposal's validity using the [`validate-cbor`](#validat

Copy link
Contributor

@ArturWieczorek ArturWieczorek Apr 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion:

If we are giving examples for creating and submitting proposal vote then maybe we can also add similar examples for update proposals with mandatory arguments:

cardano-cli -- byron create-byron-update-proposal --config configuration/defaults/liveview/config-0.yaml --signing-key configuration/defaults/liveview/genesis/delegate-keys.000.key --protocol-version-major 1 --protocol-version-minor 0 --protocol-version-alt 0 --application-name app --software-version-num 1 --system-tag linux --installer-hash da39a3ee5e6b4b0d3255bfef95601890afd80701 --filepath ProtocolUpdateProposalFile

and

cardano-cli -- byron submit-byron-update-proposal --config configuration/defaults/liveview/config-0.yaml --filepath ProtocolUpdateProposalFile --socket-path socket/node-0-socket

with example output that user should expect
Update proposal TxId: upid:b982f442

ArturWieczorek
ArturWieczorek reviewed Apr 28, 2020
View reviewed changes
@Jimbo4350 Jimbo4350 force-pushed the jordan/vote-creation-and-submission-3 branch from e9e70a9 to 00203cd Compare April 28, 2020 17:31
@Jimbo4350
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 28, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 1d7950f into master Apr 28, 2020
@iohk-bors iohk-bors bot deleted the jordan/vote-creation-and-submission-3 branch April 28, 2020 21:10
@Jimbo4350 Jimbo4350 mentioned this pull request May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturWieczorek ArturWieczorek ArturWieczorek approved these changes

Assignees
No one assigned
Labels
shelley testnet issues/PRs that need to be done for the Shelley testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jimbo4350 @ArturWieczorek