CAD-878: Trace node up time. #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodiePP
suggested changes
May 6, 2020
denisshevchenko
force-pushed
the
cad-878-node-up-time
branch
from
6c9e5bd to
106dd4e
Compare
|
@CodiePP Fixed. |
CodiePP
approved these changes
May 7, 2020
CodiePP
added
priority medium
iohk-bors bot
added a commit
to input-output-hk/cardano-benchmarking
that referenced
this pull request
May 7, 2020
46: CAD-878: Node's up time. r=CodiePP a=denisshevchenko Previously RTView calculated "Node uptime" based on start time which was a time when the first `LogObject` was received. Now node sends `LogObject` with its real up time. Corresponding changes in `cardano-node`: IntersectMBO/cardano-node#892 Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io> Co-authored-by: Alexander Diemand <codieplusplus@apax.net>
denisshevchenko
force-pushed
the
cad-878-node-up-time
branch
from
106dd4e to
c5367bc
Compare
CodiePP
force-pushed
the
cad-878-node-up-time
branch
from
c5367bc to
da8e97a
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 8, 2020
892: CAD-878: Trace node up time. r=CodiePP a=denisshevchenko Issue ----------- - Trace node's real up time. - This PR **does not result** in breaking changes to upstream dependencies. Checklist --------- - [ ] This PR contains all the work required to resolve the linked issue. - [ ] The work contained has sufficient documentation to describe what it does and how to do it. - [ ] The work has sufficient tests and/or testing. - [ ] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these. - [x] I have added the appropriate labels to this PR. Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
Build failed |
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
CodiePP
force-pushed
the
cad-878-node-up-time
branch
from
e2498f3 to
9d73780
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Trace node's real up time.
This PR does not result in breaking changes to upstream dependencies.
Checklist
This PR contains all the work required to resolve the linked issue.
The work contained has sufficient documentation to describe what it does and how to do it.
The work has sufficient tests and/or testing.
I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.
I have added the appropriate labels to this PR.