-
Notifications
You must be signed in to change notification settings - Fork 734
Update dependencies and support PParams value in ShelleyGenesis #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
958ccf4
to
d6e1f93
Compare
@dcoutts: If you prefer that I keep all of the keys in |
"extraEntropy": { | ||
"tag": "NeutralNonce" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Morally it's a Maybe, and a leaf one at that. So it could easily be empty/null or a hash string (as hex, which is probably already the default for that).
I don't really care provided it's consistent. We'll have to update the examples in the docs anyway. |
Right, I'll do that now. |
If you're doing that, you can also make the story simpler: if the That also gives us a cheap and cheerful way to print the defaults. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Using the defaults and writing out a genesis.spec.json
in the create-genesis
command would be an excellent bonus.
Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com>
21352cb
to
d0db4c8
Compare
genUnitInterval :: Gen UnitInterval | ||
genUnitInterval = | ||
UnsafeUnitInterval | ||
<$> Gen.realFrac_ (Range.linearFrac 0 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the hedgehog docs realFrac_
does not shrink. Should we use the double
generator here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shrinking not too important here.
bors r+ |
Build succeeded |
No description provided.