Skip to content

cli: Read local node's socket path from an environment variable #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2020
Merged

cli: Read local node's socket path from an environment variable #917

merged 1 commit into from
May 10, 2020

Conversation

erikd
Copy link
Contributor

@erikd erikd commented May 10, 2020

No description provided.

@erikd
cli: Read local node's socket path from an environment variable
198abd2 
Read from the NODE_SOCKET_PATH environment variable.
@erikd erikd requested review from dcoutts and Jimbo4350 May 10, 2020 05:57
Jimbo4350
Jimbo4350 approved these changes May 10, 2020
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there somewhere in the docs we could indicate that we are expecting an environmental variable for the socket path?

@erikd
Copy link
Contributor Author

erikd commented May 10, 2020

There will be something in the docs

@erikd
Copy link
Contributor Author

erikd commented May 10, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 10, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit f61733d into master May 10, 2020
@iohk-bors iohk-bors bot deleted the erikd/socket-env branch May 10, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikd @Jimbo4350