Fix thunks in Shelley #1928
Merged
Fix thunks in Shelley #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on IntersectMBO/cardano-ledger#1343, but to avoid breaking/stalling things at the end of this sprint, this non-urgent change can wait until next sprint. |
mrBliss
force-pushed
the
mrBliss/fix-shelley-thunks
branch
from
074bb26 to
8ffeeaa
Compare
|
IntersectMBO/cardano-ledger#1343 got merged, but some unrelated changes got merged before it, which haven't been propagated to |
This was referenced Apr 15, 2020
mrBliss
force-pushed
the
mrBliss/fix-shelley-thunks
branch
from
8ffeeaa to
f6bb9ec
Compare
edsko
reviewed
Apr 16, 2020
| {-# OPTIONS_GHC -fno-strictness #-} | ||
| -- NOTE: With @-fstrictness@ optimisation (enabled by default for -O1), we get | ||
| -- an unexplained thunk in 'KnownIntersectionState' and thus a space leak. See | ||
| -- #1356. |
edsko
approved these changes
Apr 16, 2020
|
bors merge |
|
Let's hope CI won't block us too long this time (it did in #1947) 😩 |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 16, 2020
1928: Fix thunks in Shelley r=mrBliss a=mrBliss Fixes #1558. 1962: node to client api changes r=coot a=coot Small changes to NodeToClient api and LocalStateQuery protocol type signatures. Related to #1950 - Added null peers in NodeToNode module - Add kinds to type signatures of LocalQueryProtocol Co-authored-by: Thomas Winant <thomas@well-typed.com> Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
|
bors cancel |
|
(Bors is running a job for this PR and #1962, which was closed, so there's no point in continuing with that job 😩) |
|
bors r- |
Canceled |
|
bors merge |
Build failed |
It was accidentally bumped down in #1947.
mrBliss
force-pushed
the
mrBliss/fix-shelley-thunks
branch
from
f6bb9ec to
fe40214
Compare
|
bors merge |
|
bors ping |
|
pong |
|
bors merge |
|
Already running a review |
|
bors r- |
Canceled |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1558.