Skip to content

Optimize power rule #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize power rule #694

wants to merge 1 commit into from

Conversation

YingboMa
Copy link
Member

@YingboMa YingboMa commented Feb 15, 2023 •
edited
Loading

* is often faster than /.

@github-actions github-actions bot added the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Feb 15, 2023
@mcabbott
Copy link
Member

The hard part was getting all the weird edge cases to work. If introducing extra branches like if isinteger(p), you may need to expand the list of test cases to check both halves.

@oxinabox
Copy link
Member

@YingboMa are you going to add the missing test so we can merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs version bump Version needs to be incremented or set to -DEV in Project.toml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YingboMa @mcabbott @oxinabox