Skip to content

Missing unsafe_array_convert for StructVectors (#37) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Missing unsafe_array_convert for StructVectors (#37) #38

wants to merge 4 commits into from

Conversation

j-fu
Copy link
Member

@j-fu j-fu commented May 23, 2024

No description provided.

j-fu added 2 commits May 23, 2024 15:16
@j-fu
Remove old, non-working versions of GeometryBasics from compat
4699257
@j-fu
Remove tetrahedralize(mesh::Mesh{3, Float64, <:TetGen.Triangle}) from…
995cd79 
… input

With facet markers in the mesh, this creates the wrong entry type for facets.
Fixes #37
@j-fu j-fu requested a review from SimonDanisch May 23, 2024 13:23
@j-fu j-fu changed the title Try to fix #37 by removing special method for meshes with trifacets Missing unsafe_array_convert for StructVectors (#37) Jul 12, 2024
@j-fu
Copy link
Member Author

j-fu commented Jul 12, 2024

Hi @SimonDanisch, had a deeper look into the problem.
It occurs that the README example did not survive the transition of GeometryBasics to StructVectors. I added the example to the tests. It probably is a quick fix for you to add the missing method (I tried but failed so far).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonDanisch SimonDanisch Awaiting requested review from SimonDanisch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-fu