Fixes #16 - check for required executables #40
Conversation
This change will check if our required binaries are available. If not, a more helpful error is thrown. AFAIK, this works only on Linux/MacOS - but I see no limitations here since we already targeting Linux only.
|
I added two commits since several files will conflict. I can open a second PR if really necessary though (and hope it will not be :). |
helge000
force-pushed
the
fix-16
branch
4 times, most recently
from
cc7059a to
b092126
Compare
Uses -E in the in cli and checkbox in GUI
|
The 3rd commit stems from my trouble inserting a row in the current TK UI. I think it should simply be squashed with #27 enhancement; but separate commit makes changes more obvious. |
|
Thanks @helge000 for this pull request, these modifications look really useful! It might take me some time to do an in-depth review, because I'm currently a bit busy working on other things, and the tape reading hardware setup I'm using is located outside my office in another part of the building. But I'll definitely get around to this, and will merge once I've verified everything works. Pleased to see people are actually using this tool! |
|
@bitsgalore, no problem, take your time! Found this via stack overflow where it was recommended - and ran into both issues ( |
| @@ -9,6 +9,8 @@ | |||
| import subprocess as sub | |||
| import pytz | |||
|
|
|||
| REQUIRED_CMDS = ['mt', 'dd'] | |||
There was a problem hiding this comment.
I guess the easiest way to test 7be2ec3 is to add a non existing command here
This change will check if our required binaries are available. If not,
a more helpful error is thrown.
AFAIK, this works only on Linux/MacOS - but I see no limitations here
since we already targeting Linux only.