Batcher update #80
Open
Batcher update #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadelineAu
requested review from
samlaf,
dabit3,
shrimalmadhur,
antojoseph,
NimaVaziri,
scotthconner,
MC1823315,
mmurrs,
non-fungible-nelson and
afkbyte
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
samlaf
reviewed
Jul 14, 2025
| Privileged roles that are responsible for submitting rollup batches to EigenDA. | ||
|
|
||
| Use the `eigenda.v2.cert-verifier-router-or-immutable-verifier-addr` option to specify the address of either the `EigenDACertVerifierRouter` | ||
| or immutable `EigenDACertVerifier` contract. Required for performing `eth_call` to verify EigenDA certificates. |
There was a problem hiding this comment.
Suggested change
| or immutable `EigenDACertVerifier` contract. Required for performing `eth_call` to verify EigenDA certificates. | |
| or immutable `EigenDACertVerifier` contract. Required for building the correct versioned cert, as well as performing `eth_call` to verify the constructed EigenDA certificates before returning them. |
samlaf
previously approved these changes
Jul 16, 2025
There was a problem hiding this comment.
LGTM, although I would remove the "Privileged roles" part because different rollups have different permissions wrt who can be batcher (they are centralized right now for the most part but there is a decentralization roadmap). Also it sounds like the privileged is wrt eigenda and not wrt to the rollup.
samlaf
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cert verification always enabled in v2