test: add dataapi tests to ci and fix them #1764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataapi tests were not running in ci. Created a single integration-tests target which runs all of them. This way its impossible to forget one.
This way dataapi tests will now be running.
|
@pschork the dataapi tests are, unsurprisingly, failing. Can you take a look? |
dmanc
reviewed
Jul 14, 2025
| @@ -107,4 +81,5 @@ jobs: | |||
| "commit_sha": "https://github.com/Layr-Labs/eigenda/commit/${{ github.sha }}" | |||
| } | |||
| env: | |||
| # TODO: which channel is this being sent to? | |||
Previous makefile target was broken, as it wasnt used in ci.
This fixes thue integration test in ci which was failing because anvil was failing to start.
Otherwise anvil was failing to start silently
|
The latest Buf updates on your PR. Results from workflow Buf Proto / buf (pull_request).
|
flag name has changed, and it was moved to live tests (aka TODO was done in another PR).
No idea how to fix it and don't feel like fixing it right now.
dmanc
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
dataapi tests were not running in ci. Created a single integration-tests target which runs all of them. This way its impossible to forget one.
Also refactored some test targets in makefile to make distinction between each clearer. Having too many targets is just confusing, and leads to errors like this.
Checks