feat(tools): new eigenda contract addresses reading cli #1804

samlaf · 2025-07-25T12:31:21Z

Why are these changes needed?

My endgoal target is to create a "discovery" CLI (hence the name) that given a network would discover all addresses (contracts, disperser/relays URLs, operator IPs, etc). This means it should probably incorporate the quorumscan tool, and others. I think ideally we would merge all of them into a single eigenda CLI with subcommands, which would be easier to use for everyone.

Right now it only discovers contract address by reading them from the EigenDADirectory address provided (or using the default one for the chain-id or network provided).
Given an eth-rpc it prints a table, json, or csv output of all contract names and their address.

Checks

I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
I've checked the new test coverage and the coverage percentage didn't drop.
Testing Strategy
- Unit tests
- Integration tests
- This PR is not tested :(

This is used to fetch all addresses from a given EigenDADirectory

Given an eth-rpc it prints a table, json, or csv output of all contract names and their address.

github-actions · 2025-07-25T12:31:42Z

The latest Buf updates on your PR. Results from workflow Buf Proto / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`✅ passed`	Jul 25, 2025, 12:31 PM

litt3 · 2025-07-25T14:00:12Z

api/proxy/common/eigenda_network.go

+	if len(networks) == 0 {
+		return "", fmt.Errorf("no EigenDA network found for chain ID: %s", chainID)
+	}
+	return networks[0], nil


I think it make more sense to only do this default selection iff len(networks) == 1.

In cases where there are multiple options, seems safer to make the user explicitly choose, instead of potentially choosing the wrong one

litt3 · 2025-07-25T14:01:26Z

core/eth/eigenda_directory_reader.go

@@ -64,4 +63,23 @@ func (r *EigenDADirectoryReader) GetServiceManagerAddress() (gethcommon.Address,
 	return r.getAddressWithValidation(ContractNames.ServiceManager)
 }

+// GetAllAddresses returns all contract addresses from the directory in a map keyed by contract name
+func (r *EigenDADirectoryReader) GetAllAddresses() (map[string]gethcommon.Address, error) {
+	names, err := r.contract.GetAllNames(&bind.CallOpts{})


no timeout?

litt3 · 2025-07-25T14:02:26Z

core/eth/eigenda_directory_reader.go

+func (r *EigenDADirectoryReader) GetAllAddresses() (map[string]gethcommon.Address, error) {
+	names, err := r.contract.GetAllNames(&bind.CallOpts{})
+	if err != nil {
+		return nil, fmt.Errorf("failed to get all contract names: %w", err)


Your error messages in this method include "failed to"

litt3 · 2025-07-25T14:06:03Z

core/eth/eigenda_directory_reader.go

+
+	addresses := make(map[string]gethcommon.Address)
+	for _, name := range names {
+		addr, err := r.contract.GetAddress0(&bind.CallOpts{}, name)


no timeout?

litt3 · 2025-07-25T14:07:15Z

core/eth/eigenda_directory_reader.go

+
+	return addresses, nil
+}
+
 // TODO: add other getters for other contracts; they are not needed for the current usage


I notice you don't attribute TODOs to yourself, e.g. TODO(samlaf). Any reason? Curious your thoughts on the attribution- when I wrote the style guide I included it as a soft requirement, but we could roll that back if you disagree

litt3 · 2025-07-25T14:18:04Z

tools/discovery/main.go

+			}
+			directoryAddr, err = network.GetEigenDADirectory()
+			if err != nil {
+				return fmt.Errorf("error getting EigenDADirectory address for network %s: %w", network, err)


Here too you're prefixing errors with words like "error getting". Intentional, or LLM not following your preferences?

litt3 · 2025-07-25T14:19:56Z

tools/discovery/main.go

+			if err != nil {
+				return err
+			}
+			directoryAddr, err = network.GetEigenDADirectory()


I know the logger output is slightly different, but theoretically you could pull this code out of the if else, since both branches are doing essentially the same thing

directoryAddr, err = network.GetEigenDADirectory() if err != nil { return fmt.Errorf("error getting EigenDADirectory address for network %s: %w", network, err) } logger.Printf("Auto-detected EigenDADirectory address %s for network %s", directoryAddr, networkName)

litt3 · 2025-07-25T14:20:46Z

tools/discovery/main.go

+		return fmt.Errorf("failed to create EigenDADirectory reader: %w", err)
+	}
+
+	// Get all addresses


not exactly a helpful comment on a method called GetAllAddresses

litt3 · 2025-07-25T14:21:40Z

tools/discovery/main.go

+func printTable(addressMap map[string]gethcommon.Address) {
+	t := table.NewWriter()
+	t.SetOutputMirror(os.Stdout)
+	t.AppendHeader(table.Row{"Contract Name", "Address"})


Contract Name and Address are duplicated strings in this file

litt3 · 2025-07-25T14:22:00Z

tools/discovery/main.go

+		if i == len(addressMap)-1 {
+			comma = ""
+		}
+		fmt.Printf("  {\"name\": \"%s\", \"address\": \"%s\"}%s\n", name, addr.Hex(), comma)


any reason to just use name here, instead of contract_name, as with the other print methods?

litt3 · 2025-07-25T14:25:26Z

Can you also post an example of the other output types?

litt3 · 2025-07-25T14:36:18Z

tools/discovery/main.go

+)
+
+const (
+	ethRpcUrlFlagName        = "eth-rpc-url"


I'm not a fan of how we handle string literals when doing flag+env configurations.

All the flag names are specified as const strings at the top, but then the env var name string is defined far away, where the flag struct is initialized. Modifying a name is tedious at best, and error prone at worst (e.g., the flag name gets changed, but the env name is forgotten)

If we had a simple struct, named FlagAndEnvField (or something better...) which contains fields for FlagName, and EnvVarName, then the relevant names for a given field would be right next to each other, and it would be easier to keep them properly in sync.

May or may not make sense to start such a system in this PR. It's just a painpoint I've noticed before, that probably would be good to address at some point.

pschork · 2025-07-25T19:49:59Z

api/proxy/common/eigenda_network.go

 func EigenDANetworkFromString(inputString string) (EigenDANetwork, error) {
 	network := EigenDANetwork(inputString)

 	switch network {
 	case HoleskyTestnetEigenDANetwork, HoleskyPreprodEigenDANetwork, SepoliaTestnetEigenDANetwork, MainnetEigenDANetwork:
 		return network, nil
 	default:
-		return "", fmt.Errorf("unknown network type: %s", inputString)
+		allowedNetworks := []string{
+			MainnetEigenDANetwork.String(),


MainnetBeta missing

samlaf added 4 commits July 25, 2025 18:32

wip

dd946fc

feat(directory_reader): add new GetAllAddresses method

0a3893e

This is used to fetch all addresses from a given EigenDADirectory

chore(proxy_common): small improvements to network utils

33b16c6

feat(tools): new contract discovery cli

2669119

Given an eth-rpc it prints a table, json, or csv output of all contract names and their address.

samlaf requested a review from a team as a code owner July 25, 2025 12:31

litt3 approved these changes Jul 25, 2025

View reviewed changes

litt3 reviewed Jul 25, 2025

View reviewed changes

pschork reviewed Jul 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(tools): new eigenda contract addresses reading cli #1804

feat(tools): new eigenda contract addresses reading cli #1804

samlaf commented Jul 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025

Uh oh!

litt3 commented Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025 •

edited

Loading

Uh oh!

pschork Jul 25, 2025

Uh oh!

Uh oh!

feat(tools): new eigenda contract addresses reading cli #1804

Are you sure you want to change the base?

feat(tools): new eigenda contract addresses reading cli #1804

Conversation

samlaf commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are these changes needed?

Checks

Uh oh!

github-actions bot commented Jul 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

litt3 commented Jul 25, 2025

Uh oh!

litt3 Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samlaf commented Jul 25, 2025 •

edited

Loading

litt3 Jul 25, 2025 •

edited

Loading