Allow re-authentication if authentication failed

[andersfugmann]

This change reverts broken logic that prevented re-authentication when self._error_report is true. I dont think self._error_report is meant to be for control flow beyond limiting error reporting.

This problem was initially reported in this comment

This change allows home-assistant to successfully reconnect to the W215 after losing connection

[andersfugmann]

Ping @LinuxChristian

[LinuxChristian]

@andersfugmann thanks for submitting this. Have you tested it on a physical device? I don’t have any working W215 to test with.

[andersfugmann]

@LinuxChristian Yes. Its working like a charm on three connected dlink w215 devices controlled by home-assistant. Without the changes, home-assistant is not able to re-connect if connection is lost (e.g. if the devices are power-cycled). This PR fixes that.

[LinuxChristian]

Thanks @andersfugmann - I have created a new release (v0.8) that you can add to the official hass repo to make it the default version. Then all hass users can benefit from it.

I have also added you to this repo as co-owner in case you have other fixes.

[andersfugmann]

Thanks a lot. Have you uploaded the release to pypi?
The home-assistant dlink smartplug integration fetches dependencies though pip/uv. See https://github.com/home-assistant/core/blob/dev/homeassistant/components/dlink/manifest.json.

I'll create a PR to update the dependencies once the new version is available on pypi.

[LinuxChristian]

Will upload it tomorrow. Do you have a PyPI user?

[andersfugmann]

No, I dont have a PyPI user :-)

[LinuxChristian]

Please validate that the package works - It has been a while since I released to pypi last time.

https://pypi.org/manage/project/pyW215/release/0.8.0/

[andersfugmann]

Tested and verified. Also created PR tp update depdendencies for the dlink integration for home-assistant to use 0.8.0: home-assistant/core#147534