Fix pwa conflicting/missing entries in cache list #1868
Merged
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bugfix
Overview
When enableServiceWorker set to true, Service Worker was unable to registered because of the following reason.
This is because the precache-manifest has two manifest.json.
And the default Express static file configuration excludes dotfiles (e.g. .nojekyll), causing precache files to return 404 errors during service worker installation.
https://cli.vuejs.org/core-plugins/pwa.html#configuration
https://developer.chrome.com/docs/workbox/modules/workbox-build?hl=zh-cn#type-GlobPartial
Accouding to the docs, we just need to remove the manifestPath config, and also exclude .nojekyll/.gitignore.
Code Quality Checklist (Please complete)