Skip to content

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Oct 30, 2023

Submodules that have git@github.com:person/repo url don't work when ssh or ssh keys are not set up properly, for example in minimal automated build environments like Nix. Use the https://github/person/repo url instead for more compatibility.

Closes #2396

@carsakiller
Copy link
Collaborator

Whoops, thanks!

@carsakiller carsakiller merged commit 4088f56 into LuaLS:master Oct 30, 2023
@gepbird gepbird deleted the prefer-https-submodules branch October 30, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot check out git submodules since LuaCATS transition
2 participants