build: use docker to build linux-x64 glibc #2658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar fix to #1835, but uses independent docker environment instead of GitHub Workflow container. Fixes the issue #1828.
The
action/checkout@v4usesnode20depends on newer GLIBC version, which is not available in old docker image, e.g.,ubuntu-18.04. We don't want the image has newer version of glibc because we want to build binary using older version of GLIBC. Because the container will be evoked at start of the job, usingaction/checkout@v4causes the errors. Therefore, moving build steps into independent docker environment is the easiest way to build with old GLIBC version, and not affecting the GitHub Workflow.