Remove hardcoded values and use train() and evaluate() functions' input parameters #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correction: Make use of input parameters instead of hardcoding
Correction: Manipulate the input parameters to the functions instead of hardcoding
Change the input parameter of the evaluate function from trainset_loader to testset_loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the train and evaluate functions, the input parameters are not used in any part of the code. Instead, the places where the input parameters need to be used, the values have been hardcoded. Therefore, the user might pass wrong parameters to the function and the code would still function properly. To avoid this, I removed the hardcoded values and made use of the input value for the train and evaluate functions. I made changes to both the MNIST task and solution files.