tracking: breaking changes / regressions with neovim 0.11

[MeanderingProgrammer]

Neovim has been overhauling the internal treesitter logic to improve performance as well as adding new extmark options. Both of these are awesome and I'll need to take a closer look into what will be available and see how I can take advantage of these new features!

However, separately from this, due to this plugins assumptions about how treesitter parsing works (sync) and how default highlights behave there are also going to be some breaking changes / regressions in behavior that I'll need to patch. I'll track these regressions as I find out about them as well as the progress on fixing them here.

fenced code block delimiters now hidden with conceal_lines

• report: bug: CodeBlock not works #351
• related changes:
  • nvim-treesitter/nvim-treesitter@93ce9fe
  • feat(marks): add conceal_lines to nvim_buf_set_extmark() neovim/neovim#31324
• info: I'm tempted to ship my own highlights with this plugin to avoid the headache of un-concealing a concealed line, but I'd really rather avoid it. I think users being able to interact with tools as they usually would and having this plugin handle these changes is a good thing, and lets people implement their own custom logic without needing features added to the plugin codebase.
• status: FIXED (595ac4f) (e6c8081)
  • Created issues in neovim to help resolve some problems along the way:
    • virt_lines + conceal_lines cause window to display incorrect lines neovim/neovim#32744
    • conceal_lines + scheduled virt_lines cause incorrect cursor position neovim/neovim#32762
    • virt_lines + conceal_lines on top line cause window to display incorrect lines neovim/neovim#33033

rendering unfocussed lsp hover docs buffers

• report: How make the plugin render on unfocused markdown windows, because currently for me it only renders when cursor enters the window (lsp.buf.hover). #333
• related changes:
  • fix(lsp): set floating window filetype after context setup neovim/neovim#32112
• info: Problem is occurring because the BufWinEnter event is triggering before the FileType event, not the case in 0.10.
• status: FIXED (b57d51d) (059f503)

async parsing

• report: NONE
• related changes:
  • feat(treesitter): async parsing neovim/neovim#31631
• info: Calling parse like we do now should result in synchronous parsing for the specified range, so I don't think any changes are needed, at least for now.
• status: NO_FIX_REQUIRED

[danclave]

Thanks for the continued effort!

[chiendo97]

Hi @MeanderingProgrammer,

I stumbled upon this issue from this issue #351

May I ask if we have any good news or updates?

Thank you for your hard work.

[MeanderingProgrammer]

I have a working implementation but there are still strange behaviors with conceal lines & virtual lines, I'll need to create minimal repros for them and cut issues to neovim but do not have the time ATM.

I'll likely release the change in whatever state it happens to be in when 0.11 is officially released (I believe that's in a month or so).

[MeanderingProgrammer]

After e6c8081, there should be no more regressions

[chiendo97]

Thank you @MeanderingProgrammer for the fixes.

For me, I prefer this option to have the same behavior as previously.

    {
        "MeanderingProgrammer/render-markdown.nvim",
        -- enabled = false,
        opts = {
            code = {
                border = "none",
            },
        },
        ft = { "markdown" },
    },

[MeanderingProgrammer]

@chiendo97 are you saying the behavior changed for border = "none", if so in what way?

[MeanderingProgrammer]

@chiendo97 I think I see what you mean, the new behavior adds a highlight to the background of languages when border is none.

I added a way to get the old behavior here: a1fc4e5, but its controlled by a new option.

I needed to separate the language section from the border section to accommodate the new hide border value. I like having the language section the same color as the code body and hiding the bottom border, but it's unclear whether that should happen for everyone, and there was no way to change the behavior.

Anyway to get the old behavior use highlight_border = false:

    {
        "MeanderingProgrammer/render-markdown.nvim",
        -- enabled = false,
        opts = {
            code = {
                highlight_border = false,
            },
        },
        ft = { "markdown" },
    },

[chiendo97]

Thank you @MeanderingProgrammer for the new option. It works well as usual.

hiding the bottom border, but it's unclear whether that should happen for everyone, and there was no way to change the behavior.

Like you said, I prefer not to hide any line from the rendering of my Markdown. Because it would make me confused when I switch between modes or when I move to that line.

What I love about your plugin is that by default, there is no hidden line (aka conceal_lines) with the default config.