-
Notifications
You must be signed in to change notification settings - Fork 610
feat: Add support for AssetSelector
and AccountSelector
in snaps-jest
#3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b2df87
to
83d8449
Compare
7133570
to
79ed243
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3462 +/- ##
==========================================
+ Coverage 98.21% 98.22% +0.01%
==========================================
Files 404 405 +1
Lines 11336 11412 +76
Branches 1766 1779 +13
==========================================
+ Hits 11134 11210 +76
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AssetSelector
and AccountSelector
in snaps-jest
AssetSelector
and AccountSelector
in snaps-jest
Mrtenz
requested changes
Jun 18, 2025
packages/examples/packages/send-flow/src/test-utils/ constants.ts
Outdated
Show resolved
Hide resolved
packages/examples/packages/send-flow/src/test-utils/ constants.ts
Outdated
Show resolved
Hide resolved
Mrtenz
reviewed
Jun 19, 2025
packages/examples/packages/send-flow/src/test-utils/ constants.ts
Outdated
Show resolved
Hide resolved
Mrtenz
reviewed
Jun 23, 2025
Mrtenz
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the snaps simulation to support
AssetSelector
andAccountSelector
while also refactoring the send flow example to use those.Fixes: #3436 #3437